fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/27871 )

Change subject: firmware/apps/rssi: fix -Wmaybe-uninitialized in handle_pm() ......................................................................

firmware/apps/rssi: fix -Wmaybe-uninitialized in handle_pm()

In this function we have the following condition:

if (pm_mode == PM_IDLE && (mode == MODE_MAIN || mode == MODE_SPECTRUM))

so the 'mode' can be either MODE_MAIN or MODE_SPECTRUM. Still, GCC throws false-positive warnings that 'a' and 'e' may be used uninitialized in handle_pm().

Let's eliminate these warnings by using 'if-else' statement.

Change-Id: I86d241c41d4de135f4cd79f56f7fdd18696b7890 --- M src/target/firmware/apps/rssi/main.c 1 file changed, 1 insertion(+), 2 deletions(-)

Approvals: Jenkins Builder: Verified laforge: Looks good to me, but someone else must approve pespin: Looks good to me, but someone else must approve fixeria: Looks good to me, approved

diff --git a/src/target/firmware/apps/rssi/main.c b/src/target/firmware/apps/rssi/main.c index 9a3f87c..94ecc3b 100644 --- a/src/target/firmware/apps/rssi/main.c +++ b/src/target/firmware/apps/rssi/main.c @@ -920,8 +920,7 @@ a |= ARFCN_UPLINK; e = a; pm_mode = PM_SENT; - } - if (mode == MODE_SPECTRUM) { + } else { /* mode == MODE_SPECTRUM */ if (pcs && arfcn >= PCS_MIN && arfcn <= PCS_MAX) { a = PCS_MIN | ARFCN_PCS; e = PCS_MAX | ARFCN_PCS;