Attention is currently required from: dexter, laforge.

fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/34687?usp=email )

Change subject: transport: show full traceback on failed reader init ......................................................................

Patch Set 4:

(2 comments)

Commit Message:

https://gerrit.osmocom.org/c/pysim/+/34687/comment/1c968293_3119e18c PS4, Line 9: failes fails?

File pySim/transport/__init__.py:

https://gerrit.osmocom.org/c/pysim/+/34687/comment/44ffb089_e7bb2c3a PS4, Line 318: except Exception as e I am wondering if we really need to catch exceptions here. All we're doing is printing the backtrace and returning `None`, right? All callers of this function check the returned value and do `sys.exit()` if it's `None`. This kinda mimics what happens when you don't catch the exceptions at all and let them raise...

I would suggest simply removing this `try-catch` block as well as all checks against `None` - this way we efficiently achieve the same result without any additional logic.