Attention is currently required from: dexter, laforge. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/34687?usp=email ) Change subject: transport: show full traceback on failed reader init ...................................................................... Patch Set 4: (2 comments) Commit Message: https://gerrit.osmocom.org/c/pysim/+/34687/comment/1c968293_3119e18c PS4, Line 9: failes fails? File pySim/transport/__init__.py: https://gerrit.osmocom.org/c/pysim/+/34687/comment/44ffb089_e7bb2c3a PS4, Line 318: except Exception as e I am wondering if we really need to catch exceptions here. All we're doing is printing the backtrace and returning `None`, right? All callers of this function check the returned value and do `sys.exit()` if it's `None`. This kinda mimics what happens when you don't catch the exceptions at all and let them raise... I would suggest simply removing this `try-catch` block as well as all checks against `None` - this way we efficiently achieve the same result without any additional logic. -- To view, visit https://gerrit.osmocom.org/c/pysim/+/34687?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I46e913a516dbc13f7610512484f515ab25d3fbae Gerrit-Change-Number: 34687 Gerrit-PatchSet: 4 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Mon, 09 Oct 2023 14:51:39 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment