Attention is currently required from: dexter, laforge.

View Change

2 comments:

• Commit Message:

  • Patch Set #4, Line 9: failes

    fails?

• File pySim/transport/__init__.py:

  • Patch Set #4, Line 318: except Exception as e

    I am wondering if we really need to catch exceptions here. All we're doing is printing the backtrace and returning `None`, right? All callers of this function check the returned value and do `sys.exit()` if it's `None`. This kinda mimics what happens when you don't catch the exceptions at all and let them raise...

    I would suggest simply removing this `try-catch` block as well as all checks against `None` - this way we efficiently achieve the same result without any additional logic.

To view, visit change 34687. To unsubscribe, or for help writing mail filters, visit settings.