Change in osmo-msc[master]: sdp_msg: add sdp_audio_codecs_cmp(), add compare flags - gerrit-log

25 Jul 2022


      Attention is currently required from: neels.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/28783 )
Change subject: sdp_msg: add sdp_audio_codecs_cmp(), add compare flags
......................................................................
Patch Set 1:
(1 comment)
File src/libmsc/sdp_msg.c:
https://gerrit.osmocom.org/c/osmo-msc/+/28783/comment/1235fd30_f2d71afb 
PS1, Line 38: int sdp_audio_codec_cmp(const struct sdp_audio_codec *a, const struct sdp_audio_codec *b,
This becomes quite difficult to gasp, and seems to be doing too many things.
What about actually have 2 separate cmp functions, one comparing strings ang the other comparing specific parsed stuff?
-- 
To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/28783
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Change-Id: I18d33e189674229501afec950aa1c732386455a2
Gerrit-Change-Number: 28783
Gerrit-PatchSet: 1
Gerrit-Owner: neels nhofmeyr@sysmocom.de
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin pespin@sysmocom.de
Gerrit-Attention: neels nhofmeyr@sysmocom.de
Gerrit-Comment-Date: Mon, 25 Jul 2022 11:49:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment