Attention is currently required from: laforge, pespin.
fixeria has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/37964?usp=email )
Change subject: pfcp_peer: do not route incoming PDUs without SEID
......................................................................
Patch Set 5: Code-Review+2
(1 comment)
File src/pfcp_peer.erl:
https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/37964/comment/a38670cd_c6b64... :
PS1, Line 233: ?LOG_NOTICE("Rx unexpected PFCP PDU: ~p", [PDU])
We should at least have a metric counter though that users can observe this counter incrementing and therefore get an idea this is happening at all.
Ack, I thought the same and submitted a patch:
https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/38535
--
To view, visit
https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/37964?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: erlang/osmo-s1gw
Gerrit-Branch: master
Gerrit-Change-Id: I7d33ec4e883b217b2b4f65e4866d9365c32c753d
Gerrit-Change-Number: 37964
Gerrit-PatchSet: 5
Gerrit-Owner: fixeria
vyanitskiy@sysmocom.de
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria
vyanitskiy@sysmocom.de
Gerrit-Reviewer: laforge
laforge@osmocom.org
Gerrit-Reviewer: pespin
pespin@sysmocom.de
Gerrit-Attention: laforge
laforge@osmocom.org
Gerrit-Attention: pespin
pespin@sysmocom.de
Gerrit-Comment-Date: Fri, 25 Oct 2024 19:32:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: laforge
laforge@osmocom.org
Comment-In-Reply-To: fixeria
vyanitskiy@sysmocom.de
fixeria