[L] Change in osmo-msc[master]: vlr: add a logging layer - gerrit-log

21 Oct 2024

Attention is currently required from: laforge.

lynxis lazus has posted comments on this change by lynxis lazus. (
https://gerrit.osmocom.org/c/osmo-msc/+/38410?usp=email )

Change subject: vlr: add a logging layer
......................................................................

Patch Set 6:

(2 comments)

Patchset:

PS5: 
...
  whoy doesn't LOGVLR take a vlr as first pointer
and then print the context?  Like we usually do in o […] I only converted the code,
even there is also LOGVSUBP

File src/libvlr/vlr.c:

https://gerrit.osmocom.org/c/osmo-msc/+/38410/comment/b46b52dd_15f6ea22?usp… :
PS5, Line 457: LOGVLR(LOGL_DEBUG, "freeing VLR subscr %s (max total use count was
%d)\n", vlr_subscr_name(vsub),
...
  So I'd suggest something like `LOGVSUB(vsub,
LOGL_DEBUG, "freeing VLR subscr (max total use count wa […] Done

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/38410?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Change-Id: I6d87b38d6d7d704c7c7b2c90ad12187e4b953b8b
Gerrit-Change-Number: 38410
Gerrit-PatchSet: 6
Gerrit-Owner: lynxis lazus &lt;lynxis(a)fe80.eu&gt;
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin &lt;pespin(a)sysmocom.de&gt;
Gerrit-CC: laforge &lt;laforge(a)osmocom.org&gt;
Gerrit-Attention: laforge &lt;laforge(a)osmocom.org&gt;
Gerrit-Comment-Date: Mon, 21 Oct 2024 18:14:23 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge &lt;laforge(a)osmocom.org&gt;