fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41517?usp=email )
Change subject: s1gw: f_ConnHdlr_ue_ctx_release_req(): add a quirk for -latest ......................................................................
s1gw: f_ConnHdlr_ue_ctx_release_req(): add a quirk for -latest
We're hitting a crash in Eclipse TITAN when running S1GW_Tests.TC_uemux_ue_ctx_release_req against the -latest version of osmo-s1gw, which is sending PFCP Session Deletion Request that we no longer expect to receive. This results in an empty junit-xml file due to early termination of the runtime.
Re-introduce the f_ConnHdlr_session_delete(), only for the -latest.
Change-Id: I90c44955ad3aabfe7ca9198b3ec9b6b97a46c0ae Related: 8e315ed6 ("s1gw: correct handling of UE CONTEXT RELEASE REQUEST") Related: osmo-s1gw.git If467162e871b7989f0578be30c04d1c32c263c99 Related: OS#6888, SYS#7738, SYS#7599 --- M s1gw/S1GW_ConnHdlr.ttcn 1 file changed, 4 insertions(+), 0 deletions(-)
Approvals: osmith: Looks good to me, approved pespin: Looks good to me, but someone else must approve Jenkins Builder: Verified
diff --git a/s1gw/S1GW_ConnHdlr.ttcn b/s1gw/S1GW_ConnHdlr.ttcn index b850f55..ec6d08a 100644 --- a/s1gw/S1GW_ConnHdlr.ttcn +++ b/s1gw/S1GW_ConnHdlr.ttcn @@ -1662,6 +1662,10 @@
log("[eNB -> S1GW] -> MME: UE CONTEXT RELEASE REQUEST"); f_ConnHdlr_tx_s1ap_from_enb(ts_S1AP_UeContextReleaseReq(mme_ue_id, enb_ue_id, cause)); + /* XXX: remove this quirk when osmo-s1gw > 0.3.0 is released */ + if (Misc_Helpers.f_osmo_repo_is("latest")) { + f_ConnHdlr_session_delete(erabs); + } log("eNB -> [S1GW -> MME]: UE CONTEXT RELEASE REQUEST"); f_ConnHdlr_rx_s1ap_from_enb(pdu, tr_S1AP_UeContextReleaseReq(mme_ue_id, enb_ue_id, cause)); }