fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/30333 )

Change subject: mobile: gsm48_rr_tx_voice(): also permit TCH/H frames ......................................................................

mobile: gsm48_rr_tx_voice(): also permit TCH/H frames

The idea behind checking the ch_type in gsm48_rr_tx_voice() was likely to prevent sending of the (LCR originated) Uplink TCH frames before the actual traffic channel is established/modified.

The problem is that this check allows TCH/F frames, but not TCH/H. Most likely, TCH/H was forgotten or never tested. Fix this.

Change-Id: I06e84ad47bafd4676af0e136b825e77471587b23 Related: OS#5599 --- M src/host/layer23/src/mobile/gsm48_rr.c 1 file changed, 2 insertions(+), 2 deletions(-)

Approvals: Jenkins Builder: Verified laforge: Looks good to me, but someone else must approve msuraev: Looks good to me, but someone else must approve fixeria: Looks good to me, approved

diff --git a/src/host/layer23/src/mobile/gsm48_rr.c b/src/host/layer23/src/mobile/gsm48_rr.c index 9f159d8..41aa7b8 100644 --- a/src/host/layer23/src/mobile/gsm48_rr.c +++ b/src/host/layer23/src/mobile/gsm48_rr.c @@ -5798,8 +5798,8 @@ goto error; }

- if (ch_type != RSL_CHAN_Bm_ACCHs) { - LOGP(DRR, LOGL_INFO, "Current channel is not (yet) TCH/F\n"); + if (ch_type != RSL_CHAN_Bm_ACCHs && ch_type != RSL_CHAN_Lm_ACCHs) { + LOGP(DRR, LOGL_INFO, "Current channel is not (yet) TCH\n"); goto error; }