Attention is currently required from: jolly.
fixeria has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33150 )
Change subject: Added BSC tests for terminating voice group calls
......................................................................
Patch Set 5:
(2 comments)
File bsc/BSC_Tests_ASCI.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33150/comment/e7c0c7d7_ced6…
PS3, Line 46: type component RSL_DchanHdlr
This component type is already defined in
`library/RSL_Emulation. […]
Done
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33150/comment/2971f164_3874…
PS3, Line 59: integer cr, integer sf, integer af, integer prio, integer ci
Why not defining template parameters as `BITn`? […]
Having default values assigned here would make this template a bit easier to use,
but this is not critical. Marking as resolved.
--
To view, visit
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33150
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I6762e8adfb7d5f77df837c698ff70cd7fd715ffe
Gerrit-Change-Number: 33150
Gerrit-PatchSet: 5
Gerrit-Owner: jolly <andreas(a)eversberg.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-CC: laforge <laforge(a)osmocom.org>
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: jolly <andreas(a)eversberg.eu>
Gerrit-Comment-Date: Fri, 09 Jun 2023 14:09:39 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-MessageType: comment