Attention is currently required from: fixeria, lynxis lazus.

pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41136?usp=email )

The change is no longer submittable: Code-Review is unsatisfied now.

Change subject: stp: Introduce STP_Tests_TCAP ......................................................................

Patch Set 6: Code-Review-2

(1 comment)

File stp/expected-results.xml:

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41136/comment/d407f0d1_82334... : PS6, Line 75: <testcase classname='STP_Tests_TCAP' name='TC_tcap_loadshare_ipa_tcap_range_fail_overlap' time='MASKED'/> : <testcase classname='STP_Tests_TCAP' name='TC_tcap_loadshare_ipa_tcap_range_fail_overlap' time='MASKED'/> : <testcase classname='STP_Tests_TCAP' name='TC_tcap_loadshare_ipa_tcap_range_fail_overlap' time='MASKED'/> :

Ok, I see you're executing the same testcase with different parameters. […]

This should IMHO be fixed, ie we shouldn't have a test being run multiple times with the same name. It will make it more difficult to figure out which one failed, etc.

We always have 1 specific naming for one specific testcase everywhere.