Attention is currently required from: pespin.
daniel has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/42114?usp=email )
Change subject: xua_as_fsm: Remove TODO no longer valid
......................................................................
Patch Set 1: Code-Review+1
(1 comment)
File src/xua_as_fsm.c:
https://gerrit.osmocom.org/c/libosmo-sigtran/+/42114/comment/a98b6159_c4ea4d... :
PS1, Line 139: npar->presence &= ~NOTIFY_PAR_P_ASP_ID;
I know it's unrelated to your commit, but I *really* dislike mixed brace/no-brace blocks in if/else.
--
To view, visit
https://gerrit.osmocom.org/c/libosmo-sigtran/+/42114?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: libosmo-sigtran
Gerrit-Branch: master
Gerrit-Change-Id: I57af18dacc0470d36ddd4705a9530bd44b31f9c0
Gerrit-Change-Number: 42114
Gerrit-PatchSet: 1
Gerrit-Owner: pespin
pespin@sysmocom.de
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel
dwillmann@sysmocom.de
Gerrit-Attention: pespin
pespin@sysmocom.de
Gerrit-Comment-Date: Thu, 12 Feb 2026 15:12:47 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes