[M] Change in osmo-bsc[master]: lchan.h: remove enum lchan_csd_mode - gerrit-log

1 Mar 2023

Attention is currently required from: laforge.

osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/31545
)

Change subject: lchan.h: remove enum lchan_csd_mode
......................................................................

Patch Set 3:

(1 comment)

Commit Message:

https://gerrit.osmocom.org/c/osmo-bsc/+/31545/comment/3834bb0a_2952484e 
PS2, Line 10: But instead we can just
            : directly translate the BSSAP value to the RSL value.
...
  we can, but do we already have a related enum in the
ts48_058  header files? 
The values were there, but not yet as enum. Changed it with this patch:
https://gerrit.osmocom.org/c/libosmocore/+/31620

...
  The 48.058 split into transparent and non-transparent
also makes it slightly more complex to understand, as the uint8_t can have different
meanings. 
Changed it to an union of both enums.

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/31545
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: Ice914744da3a2084e82d125848fb69404b8e8a36
Gerrit-Change-Number: 31545
Gerrit-PatchSet: 3
Gerrit-Owner: osmith &lt;osmith(a)sysmocom.de&gt;
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin &lt;pespin(a)sysmocom.de&gt;
Gerrit-CC: laforge &lt;laforge(a)osmocom.org&gt;
Gerrit-Attention: laforge &lt;laforge(a)osmocom.org&gt;
Gerrit-Comment-Date: Wed, 01 Mar 2023 14:29:35 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge &lt;laforge(a)osmocom.org&gt;
Gerrit-MessageType: comment