Attention is currently required from: matanp. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/36019?usp=email ) Change subject: ctrl: Add lchan show ...................................................................... Patch Set 3: (1 comment) File src/osmo-bsc/bts_trx_ts_lchan_ctrl.c: https://gerrit.osmocom.org/c/osmo-bsc/+/36019/comment/8b8e12d0_34fa92c2 PS1, Line 84: interference = talloc_asprintf(cmd, "%ddBm(%u)", lchan->interf_dbm, lchan->interf_band); I don't see the point of adding the units here, plus parenthesis etc. making parsing more complex. Simply do "%d,%u", and if lchan->interf_dbm == INTERF_DBM_UNKNOWN, then use ",," -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/36019?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I5432800eae452b6df71a151a7649f228704ed0da Gerrit-Change-Number: 36019 Gerrit-PatchSet: 3 Gerrit-Owner: matanp <matan1008(a)gmail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: matanp <matan1008(a)gmail.com> Gerrit-Comment-Date: Tue, 20 Feb 2024 09:55:00 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment