Attention is currently required from: pespin.

jolly has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33150 )

Change subject: Added BSC tests for terminating voice group calls ......................................................................

Patch Set 4:

(3 comments)

File bsc/BSC_Tests_ASCI.ttcn:

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33150/comment/00734933_33504... PS1, Line 507: connect(call_conn:COORD, chan_conn:COORD);

Better add a comment here explaining that.

Done

File bsc/BSC_Tests_ASCI.ttcn:

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33150/comment/53997141_16427... PS2, Line 395: pars.asci_test := ASCI_TEST_SETUP_OK;

When I was talking into looking at possibly changing booleans to states I wasn't meaning these boole […]

Done

File bsc/MSC_ConnectionHandler.ttcn:

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33150/comment/cb14dfae_8a699... PS2, Line 798: ASCITest asci_test

I was fine with using booleans here before to tweak how the test code behaved. […]

Done