Attention is currently required from: pespin.
jolly has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33150 )
Change subject: Added BSC tests for terminating voice group calls
......................................................................
Patch Set 4:
(3 comments)
File bsc/BSC_Tests_ASCI.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33150/comment/00734933_3350…
PS1, Line 507: connect(call_conn:COORD, chan_conn:COORD);
Better add a comment here explaining that.
Done
File bsc/BSC_Tests_ASCI.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33150/comment/53997141_1642…
PS2, Line 395: pars.asci_test := ASCI_TEST_SETUP_OK;
When I was talking into looking at possibly changing
booleans to states I wasn't meaning these boole […]
Done
File bsc/MSC_ConnectionHandler.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33150/comment/cb14dfae_8a69…
PS2, Line 798: ASCITest asci_test
I was fine with using booleans here before to tweak
how the test code behaved. […]
Done
--
To view, visit
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33150
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I6762e8adfb7d5f77df837c698ff70cd7fd715ffe
Gerrit-Change-Number: 33150
Gerrit-PatchSet: 4
Gerrit-Owner: jolly <andreas(a)eversberg.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: laforge <laforge(a)osmocom.org>
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Tue, 06 Jun 2023 10:53:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: jolly <andreas(a)eversberg.eu>
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: comment