[L] Change in libosmo-abis[master]: ipaccess: Convert BTS OML & RSL link to use stream_cli - gerrit-log

28 Nov 2024

Attention is currently required from: daniel, fixeria, laforge.

pespin has posted comments on this change by pespin. (
https://gerrit.osmocom.org/c/libosmo-abis/+/38927?usp=email )

Change subject: ipaccess: Convert BTS OML & RSL link to use stream_cli
......................................................................

Patch Set 1:

(3 comments)

File src/input/ipaccess.c:

https://gerrit.osmocom.org/c/libosmo-abis/+/38927/comment/8e40abe4_ece65fd8… :
PS1, Line 494: OSMO_ASSERT(cli);
...
  If you dive into the code you'd like to put even
more asserts! […] Done

https://gerrit.osmocom.org/c/libosmo-abis/+/38927/comment/653f7f9f_0f0e862f… :
PS1, Line 545: osmo_stream_cli_send
...
  because osmo_stream_cli_send() returns void. […]
Done

https://gerrit.osmocom.org/c/libosmo-abis/+/38927/comment/89e44a92_c1c4486d… :
PS1, Line 992: err:
             : 	return -1;
...
  Yes, but I prefer having all error paths easily
visible this way. Done

-- 
To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/38927?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: libosmo-abis
Gerrit-Branch: master
Gerrit-Change-Id: I35c214fbe930c695a1475d8b4bc3dc44dff83eea
Gerrit-Change-Number: 38927
Gerrit-PatchSet: 1
Gerrit-Owner: pespin &lt;pespin(a)sysmocom.de&gt;
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel &lt;dwillmann(a)sysmocom.de&gt;
Gerrit-Reviewer: fixeria &lt;vyanitskiy(a)sysmocom.de&gt;
Gerrit-Reviewer: laforge &lt;laforge(a)osmocom.org&gt;
Gerrit-Attention: laforge &lt;laforge(a)osmocom.org&gt;
Gerrit-Attention: fixeria &lt;vyanitskiy(a)sysmocom.de&gt;
Gerrit-Attention: daniel &lt;dwillmann(a)sysmocom.de&gt;
Gerrit-Comment-Date: Thu, 28 Nov 2024 16:05:39 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin &lt;pespin(a)sysmocom.de&gt;
Comment-In-Reply-To: fixeria &lt;vyanitskiy(a)sysmocom.de&gt;