[M] Change in ...osmo-s1gw[master]: s1gw_metrics: add histograms for gen_sctp:send/3 delay - gerrit-log

27 Mar 2025

Attention is currently required from: laforge, pespin.

fixeria has posted comments on this change by fixeria. (
https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/39666?usp=email )

Change subject: s1gw_metrics: add histograms for gen_sctp:send/3 delay
......................................................................

Patch Set 4:

(1 comment)

Patchset:

PS3: 
...
  Can't gen_sctp:send be used in some sort of
non-blocking way? 
There is an option to make send non-blocking by sending `non_block_send`, but then we
still need a logic that would (periodically?) try to send again. With all these layers of
abstraction (gen_sctp), we cannot know when the socket becomes ready for sending :/

...
  Having N processes sleeping waiting to write to a
socket sounds like a bit of a nightmare to me tbh, with eg. messages inside the proxied
SCTP conn being reordered, etc. 
This approach definitely needs careful thinking and planning. I am also a bit afraid of
the complexity this would bring, especially given that the S1AP spec. explicitly requires
the message ordering to be preserved.

-- 
To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/39666?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: erlang/osmo-s1gw
Gerrit-Branch: master
Gerrit-Change-Id: I7633a6e6182bda3fca4e7562e2b780b2b9f9708f
Gerrit-Change-Number: 39666
Gerrit-PatchSet: 4
Gerrit-Owner: fixeria &lt;vyanitskiy(a)sysmocom.de&gt;
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge &lt;laforge(a)osmocom.org&gt;
Gerrit-CC: pespin &lt;pespin(a)sysmocom.de&gt;
Gerrit-Attention: laforge &lt;laforge(a)osmocom.org&gt;
Gerrit-Attention: pespin &lt;pespin(a)sysmocom.de&gt;
Gerrit-Comment-Date: Thu, 27 Mar 2025 19:23:25 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin &lt;pespin(a)sysmocom.de&gt;
Comment-In-Reply-To: fixeria &lt;vyanitskiy(a)sysmocom.de&gt;