Attention is currently required from: neels.

pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/35176?usp=email )

Change subject: mgcp_network: Allow rx of IuUP in loopback mode with set rem IP address and unset rem port ......................................................................

Patch Set 2:

(1 comment)

File src/libosmo-mgcp/mgcp_network.c:

https://gerrit.osmocom.org/c/osmo-mgw/+/35176/comment/c37e978b_9e777f73 PS2, Line 866: HACK: for IuUP, we want to reply with an IuUP Initialization ACK upon the first RTP : * messag

hmm! why is this stuff still here, we have proper IuUP support and everything about this legacy hack […]

Neels I'm not sure how's that supposed to work without that hack. IIUC the steps are: HNBGW <- MSC: RAB-Ass-Req HNBGW -> MGW: CRCX (RAN side, remote IuUP IPaddr+port not known) HNBGW <- MGW: CRCX ACK (MGW local IuuP IPaddr+port is now known) HNB <- HNBGW: RAB-Ass-Req (MGW local IuuP IPaddr+port) HNB -> MGW: IuUP Init // THE CODE YOU REMOVED IS NEEDED HERE HNB <- MGW: IuUP Init ACK HNB -> HNBGW: RAB-Ass-Resp HNBGW -> MGW: MDCX (RAN side, remote IuUP IPaddr+port is now known) HNBGW <- MGW: MDCX ACK HNBGW -> MSC: RAB-Ass-Resp

So IIUC IuUP Init happens before receiving RAB-ASs-resp, so MGW cannot know the remote IuUP IP addr + port when receiving the IuUP Init packet from HNB...