Attention is currently required from: osmith, fixeria, dexter. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/29924 )

Change subject: Move UL allocation&assign functions to gprs_ms.c ......................................................................

Patch Set 3:

(2 comments)

File src/gprs_ms.c:

https://gerrit.osmocom.org/c/osmo-pcu/+/29924/comment/440e7954_7b5e12ee PS3, Line 1091:

unrelated

I changed it to have it all the functions looks similar. It may not be 100% related but not worth having a different patch for it given the huge amount of code I'm moving around.

File src/tbf_fsm.c:

https://gerrit.osmocom.org/c/osmo-pcu/+/29924/comment/de378965_2421a586 PS3, Line 105: ul_tbf_contention_resolution_start(ul_tbf);

looks like a slight change in functionality - maybe explain in the commit message why this is needed […]

It's not really a change in in functionality, I'm just moving the function call here inside the FSM logic and dropping it from the function allocating the UL TBF.