Attention is currently required from: pespin.

lynxis lazus has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/39247?usp=email )

Change subject: gprs_gmm_util: use a RAU specific TLV dictionary ......................................................................

Patch Set 2:

(1 comment)

File src/sgsn/gprs_gmm_util.c:

https://gerrit.osmocom.org/c/osmo-sgsn/+/39247/comment/319fcdef_a1f8ed0d?usp... : PS1, Line 265: ret = tlv_parse(&rau_req->tlv, &gsm48_gmm_rau_ie_tlvdef,

struct osmo_tlv_prot_def, osmo_tlv_prot_parse()

I'm not sure if osmo_tlv_prot_def is a big help here. The IE/TLVs differ a lot between the messages (which you can also do with osmo_tlv_prot_def), but the static parts, which doesn't have a "T" of TLV are complete different from each other. Also the offsets, where the TLVs are starting are different from each message. So I would keep it as it is and migrate, if reasonable, to osmo_tlv_prot_def in a later commit.