Attention is currently required from: pespin. lynxis lazus has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/39247?usp=email ) Change subject: gprs_gmm_util: use a RAU specific TLV dictionary ...................................................................... Patch Set 2: (1 comment) File src/sgsn/gprs_gmm_util.c: https://gerrit.osmocom.org/c/osmo-sgsn/+/39247/comment/319fcdef_a1f8ed0d?us… : PS1, Line 265: ret = tlv_parse(&rau_req->tlv, &gsm48_gmm_rau_ie_tlvdef, I'm not sure if osmo_tlv_prot_def is a big help here. The IE/TLVs differ a lot between the messages (which you can also do with osmo_tlv_prot_def), but the static parts, which doesn't have a "T" of TLV are complete different from each other. Also the offsets, where the TLVs are starting are different from each message. So I would keep it as it is and migrate, if reasonable, to osmo_tlv_prot_def in a later commit. -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/39247?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I460971deeebc9977a984937c542b263d941e78df Gerrit-Change-Number: 39247 Gerrit-PatchSet: 2 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 27 Jan 2025 23:23:23 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Comment-In-Reply-To: lynxis lazus <lynxis(a)fe80.eu>