Attention is currently required from: daniel, neels, pespin, tnt.
tnt has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-iuh/+/36787?usp=email )
Change subject: ranap_common: Implement support for missing procedures
......................................................................
Patch Set 2: Code-Review+1
(4 comments)
Patchset:
PS1:
I don't really understand what this is about TBH,
just doing a quick read of the code for "unexpecte […]
Done
Patchset:
PS2:
Looks logical to me.
File src/ranap_common_ran.c:
https://gerrit.osmocom.org/c/osmo-iuh/+/36787/comment/69e96e8c_19bd53ac
PS1, Line 196: static int ran_ranap_rx_unsuccessful_msg_co(RANAP_SuccessfulOutcome_t
*imsg, ranap_message *message)
ran_ranap_rx_unsuccessful_msg_co takes a
RANAP_SuccessfulOutcome_t as param and not some RANAP_Unsuc […]
Done
https://gerrit.osmocom.org/c/osmo-iuh/+/36787/comment/300fccd4_2fecee0b
PS1, Line 247: rc =
ran_ranap_rx_unsuccessful_msg_co(&pdu->choice.successfulOutcome, message);
Not pdu->choice. […]
Done
--
To view, visit
https://gerrit.osmocom.org/c/osmo-iuh/+/36787?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-iuh
Gerrit-Branch: master
Gerrit-Change-Id: I7dea74102da8b610ff2a310c5814f5c89f08e7a6
Gerrit-Change-Number: 36787
Gerrit-PatchSet: 2
Gerrit-Owner: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de>
Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: tnt <tnt(a)246tNt.com>
Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Attention: tnt <tnt(a)246tNt.com>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: daniel <dwillmann(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 15 May 2024 15:15:45 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: tnt <tnt(a)246tNt.com>
Gerrit-MessageType: comment