Attention is currently required from: fixeria, neels. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36558?usp=email ) Change subject: msc: derive altsteps from f_expect_paging() and use them ...................................................................... Patch Set 1: Code-Review+1 (2 comments) File msc/MSC_Tests.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36558/comment/b8e1859c_eb7a… PS1, Line 2596: [] as_paging() { this is now less clear than having the as_paging_tmsi(g_pars.tmsi) or whatever, since one needs to look up what is expected there. https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36558/comment/0fcf2e1d_eea1… PS1, Line 3582: [] as_paging() { setverdict(pass); } same here, it's difficult for reader to figure out the difference between as_paging and as_paging_any. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36558?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ia0e787fc376acec09e8985a63862872eb89b53a4 Gerrit-Change-Number: 36558 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 15 Apr 2024 08:53:00 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment