Attention is currently required from: arehbein, jolly.
laforge has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-bsc/+/34969?usp=email )
Change subject: SI10: Fix uninitialized last_i index
......................................................................
Patch Set 1: Code-Review+2
(1 comment)
File src/osmo-bsc/system_information.c:
https://gerrit.osmocom.org/c/osmo-bsc/+/34969/comment/2b37ee52_8a7014a3
PS1, Line 1425: int i, last_i = -1;
iirc, we put initialized variables on their own line
I'm not aware of a general rule for that.
--
To view, visit
https://gerrit.osmocom.org/c/osmo-bsc/+/34969?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: Ia10c5e68cb2940d9360d78f606af25bb207ee55f
Gerrit-Change-Number: 34969
Gerrit-PatchSet: 1
Gerrit-Owner: jolly <andreas(a)eversberg.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-CC: arehbein <arehbein(a)sysmocom.de>
Gerrit-Attention: jolly <andreas(a)eversberg.eu>
Gerrit-Attention: arehbein <arehbein(a)sysmocom.de>
Gerrit-Comment-Date: Tue, 07 Nov 2023 12:22:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: arehbein <arehbein(a)sysmocom.de>
Gerrit-MessageType: comment