Attention is currently required from: markb, pespin.
dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/29439 )
Change subject: shell: Use a double asterisk for kwargs
......................................................................
Patch Set 5:
(1 comment)
Patchset:
PS5:
I wonder if this patch is still needed/up-to-date. At least in current master there is no kwargs parameter at all: https://gitea.osmocom.org/sim-card/pysim/src/branch/master/pySim-shell.py#L1...
--
To view, visit
https://gerrit.osmocom.org/c/pysim/+/29439
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: pysim
Gerrit-Branch: laforge/cmd2_2.4
Gerrit-Change-Id: I19d28276e73e7024f64ed693c3b5e37c1344c687
Gerrit-Change-Number: 29439
Gerrit-PatchSet: 5
Gerrit-Owner: markb
markboldyrev@gmail.com
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter
pmaier@sysmocom.de
Gerrit-Reviewer: laforge
laforge@osmocom.org
Gerrit-CC: fixeria
vyanitskiy@sysmocom.de
Gerrit-CC: pespin
pespin@sysmocom.de
Gerrit-Attention: markb
markboldyrev@gmail.com
Gerrit-Attention: pespin
pespin@sysmocom.de
Gerrit-Comment-Date: Tue, 25 Apr 2023 13:28:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment