Attention is currently required from: fixeria, neels, pespin.

laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36455?usp=email )

Change subject: msc: f_expect_paging(): fix by_tmsi arg ......................................................................

Patch Set 1:

(1 comment)

File msc/BSC_ConnectionHandler.ttcn:

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36455/comment/7df0e0f3_f4f5d... PS1, Line 1360: boolean by_tmsi := true

You already spent more time saying how much time you'd spend changing it, than actually applying the […]

I think we should in general try to write idiomatic code, whether it's python or TTCN3. If it's a huge effort/detour, ok, then we can deviate from it. Or if we simply are not knowledgeable enough in a given language. But here it really seems relatively trivial (unless I'm missing something) to do things "right".