Attention is currently required from: laforge, fixeria. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/34174 ) Change subject: gsm48_cc_tx_call_proc_…: verify bcap.transfer ...................................................................... Patch Set 2: (1 comment) File src/libmsc/gsm_04_08_cc.c: https://gerrit.osmocom.org/c/osmo-msc/+/34174/comment/aa2df5b2_f1973101 PS2, Line 1050: MNCC should not switch from e.g. CSD to speech Yes, it is during call establishment. I remember it from the OsmoDevCall talk too, but it seemed to be a feature that didn't have much/any? real world usage. I'm not 100% sure if this breaks switching during a call, but if it does and somebody needs this, we can simply revert this patch / put it behind a VTY option. On the other hand it prevents sending unexpected data on MNCC during tests and I ran into that twice and spent some time figuring out why MSC suddenly establishes a voice call. -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/34174 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: Ibb76d08cad1ac3bc3320391c89766150a2e605c3 Gerrit-Change-Number: 34174 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Thu, 24 Aug 2023 08:32:32 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: comment