fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/27694 )

Change subject: power_ctrl_params_def_reset(): set .ctrl_interval for both UL/DL ......................................................................

power_ctrl_params_def_reset(): set .ctrl_interval for both UL/DL

For the sake of consistency and code readability, initialize the power loop control interval (P_Con_INTERVAL) for both Uplink and Downlink directions in the same function.

Change-Id: Ie3d4b481cbfacf27004787616e22b6f8a863b47b --- M src/osmo-bsc/gsm_data.c 1 file changed, 5 insertions(+), 4 deletions(-)

git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/94/27694/1

diff --git a/src/osmo-bsc/gsm_data.c b/src/osmo-bsc/gsm_data.c index 38d8a7c..5fba05f 100644 --- a/src/osmo-bsc/gsm_data.c +++ b/src/osmo-bsc/gsm_data.c @@ -1142,8 +1142,6 @@ .inc_step_size_db = 4, /* 2, 4, or 6 dB */ .red_step_size_db = 2, /* 2 or 4 dB */

- .ctrl_interval = 1, /* Trigger loop every second SACCH block. TS 45.008 sec 4.7.1 */ - /* RxLev measurement parameters */ .rxlev_meas = { .enabled = true, @@ -1338,9 +1336,12 @@ { *params = power_ctrl_params_def; params->dir = dir; + + /* Trigger loop every N-th SACCH block. See 3GPP TS 45.008 section 4.7.1. */ if (dir == GSM_PWR_CTRL_DIR_UL) - /* Trigger loop every fourth SACCH block (1.92s). TS 45.008 sec 4.7.1: */ - params->ctrl_interval = 2; + params->ctrl_interval = 2; /* N=4 (1.92s) */ + else + params->ctrl_interval = 1; /* N=2 (0.960) */ }

enum rsl_cmod_spd chan_mode_to_rsl_cmod_spd(enum gsm48_chan_mode chan_mode)