Attention is currently required from: pespin, fixeria.
dexter has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-bsc/+/30876
)
Change subject: pcu_sock: rework check logic for ts
......................................................................
Patch Set 3:
(1 comment)
File src/osmo-bsc/pcu_sock.c:
https://gerrit.osmocom.org/c/osmo-bsc/+/30876/comment/0f636449_87e11547
PS2, Line 96: static bool ts_is_pdch(const struct gsm_bts_trx_ts *ts)
ts_should_be_pdch() in osmo-bts. […]
This
function probably needs to be extended later. As far as I can see the RBS should support
dynamic timeslots. At least in the OM2000 TS configuration request I see nothing special
when the TS is set up that I later use as PDCH. It probably just depends on the channel
activation.
--
To view, visit
https://gerrit.osmocom.org/c/osmo-bsc/+/30876
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: Icaab52ab73c38889dfadb523b89bb54cafacc99a
Gerrit-Change-Number: 30876
Gerrit-PatchSet: 3
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Tue, 10 Jan 2023 11:41:22 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: comment