Attention is currently required from: fixeria. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/29114 ) Change subject: contrib/libosmo-gprs.spec.in: properly define RPM packages ...................................................................... Patch Set 3: (2 comments) File contrib/libosmo-gprs.spec.in: https://gerrit.osmocom.org/c/libosmo-gprs/+/29114/comment/23f50b17_194e3082 PS2, Line 72: --includedir="%_includedir/%name" removing --enable-shared works, but apparently --disable-static is not the default. when I remove it, the build fails with: [ 28s] Installed (but unpackaged) file(s) found: [ 28s] /usr/lib64/libosmo-csn1.a [ 28s] /usr/lib64/libosmo-gprs-rlcmac.a updated the patch to remove --enable-shared https://gerrit.osmocom.org/c/libosmo-gprs/+/29114/comment/21e4f0f2_f18a9d87 PS2, Line 77: find "%buildroot/%_libdir" -type f -name "*.la" -delete the rpm build actually fails if there are additional files -- To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/29114 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-gprs Gerrit-Branch: master Gerrit-Change-Id: I9be45c43ba3e342e1dba4b60561880c00841f549 Gerrit-Change-Number: 29114 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-CC: Jenkins Builder Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Thu, 18 Aug 2022 08:48:21 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: comment