Attention is currently required from: fixeria. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/29114 )

Change subject: contrib/libosmo-gprs.spec.in: properly define RPM packages ......................................................................

Patch Set 3:

(2 comments)

File contrib/libosmo-gprs.spec.in:

https://gerrit.osmocom.org/c/libosmo-gprs/+/29114/comment/23f50b17_194e3082 PS2, Line 72: --includedir="%_includedir/%name"

Both --disable-static and --enable-shared are implicit defaults. […]

removing --enable-shared works, but apparently --disable-static is not the default. when I remove it, the build fails with:

[ 28s] Installed (but unpackaged) file(s) found: [ 28s] /usr/lib64/libosmo-csn1.a [ 28s] /usr/lib64/libosmo-gprs-rlcmac.a

updated the patch to remove --enable-shared

https://gerrit.osmocom.org/c/libosmo-gprs/+/29114/comment/21e4f0f2_f18a9d87 PS2, Line 77: find "%buildroot/%_libdir" -type f -name "*.la" -delete

Interesting. This is something I also noticed while looking at *. […]

the rpm build actually fails if there are additional files