Attention is currently required from: osmith. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc-nat/+/27462 ) Change subject: bsc_nat_sccp_inst: rename from bsc_nat_ss7_inst ...................................................................... Patch Set 1: Code-Review+1 (1 comment) File src/osmo-bsc-nat/bsc_nat.c: https://gerrit.osmocom.org/c/osmo-bsc-nat/+/27462/comment/8465f561_9fd6f9b7 PS1, Line 36: talloc_set_name_const(bsc_nat->cn, "struct bsc_nat_sccp_inst (CN)"); for a followup patch. It probably makes no sense adding the struct name in the name, since it probably shows up automatically already in reports? -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc-nat/+/27462 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc-nat Gerrit-Branch: master Gerrit-Change-Id: Id0f965811eff0eb7b387d5ae2eec2451d6d8e415 Gerrit-Change-Number: 27462 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Thu, 10 Mar 2022 14:58:46 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment