Attention is currently required from: laforge. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-cbc/+/28718 ) Change subject: Avoid changing peer's protocol once set ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: @laforge I'm not really happy about the fact that "protocol" needs to be set under the node as a command, there's no good way to prevent it from not being set. It'd be great to have that set at creation time of the peer, so I propse: * adding a new "peer proto NAME" cmd * deprecating "peer NAME" (translate to "peer cbsp NAME" internally, for older release compat). * deprecating VTY cmd "protocol (cbsp|sbcap)" (make it a NO-OP) And of course not merging this commit as it is when applying the above. -- To view, visit https://gerrit.osmocom.org/c/osmo-cbc/+/28718 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-cbc Gerrit-Branch: master Gerrit-Change-Id: I47756dddd8f9b8450ba14c914614fd2391d5486e Gerrit-Change-Number: 28718 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Thu, 21 Jul 2022 20:01:05 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment