Attention is currently required from: pespin.

osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/33981 )

Change subject: rlcmac: Use enum gprs_rlcmac_radio_priority internally everywhere ......................................................................

Patch Set 2:

(2 comments)

File src/rlcmac/gre.c:

https://gerrit.osmocom.org/c/libosmo-gprs/+/33981/comment/81395015_3aadbc26 PS2, Line 226: ll_pdu_len, get_value_string(osmo_gprs_rlcmac_llc_sapi_names, sapi), radio_prio + 1); I wonder if it made sense to adjust the enum in types_private.h:

``` /* TS 44.060 Table Table 11.2.5. "Radio Priority" */ enum gprs_rlcmac_radio_priority { GPRS_RLCMAC_RADIO_PRIORITY_1 = 0, /* Radio Priority 1 (Highest priority) */ GPRS_RLCMAC_RADIO_PRIORITY_2 = 1, /* Radio Priority 2 */ GPRS_RLCMAC_RADIO_PRIORITY_3 = 2, /* Radio Priority 3 */ GPRS_RLCMAC_RADIO_PRIORITY_4 = 3, /* Radio Priority 4 (Lower priority) */ }; ``` to add GPRS_RLCMAC_RADIO_PRIORITY_INVALID = 0 and shift the rest. Then it wouldn't be necessary to add the +1 here. What do you think about that?

File tests/rlcmac/rlcmac_prim_test.c:

https://gerrit.osmocom.org/c/libosmo-gprs/+/33981/comment/b951568f_6e6e67da PS2, Line 991: 2 2 instead of 1 on purpose?