Attention is currently required from: laforge, fixeria.
dexter has posted comments on this change. (
https://gerrit.osmocom.org/c/pysim/+/33692 )
Change subject: pySim/cards: Add type annotations
......................................................................
Patch Set 6:
(1 comment)
File pySim/cards.py:
https://gerrit.osmocom.org/c/pysim/+/33692/comment/882c35e5_2605ae79
PS6, Line 36: def __init__(self, scc: LinkBase):
PEP-0484 says we should ("ought"), but
it's not strictly necessary, see:
https://stackoverflow. […]
Ack
--
To view, visit
https://gerrit.osmocom.org/c/pysim/+/33692
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: Id5752a64b59097584301c860ebf74d858ed3d240
Gerrit-Change-Number: 33692
Gerrit-PatchSet: 6
Gerrit-Owner: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 17 Jul 2023 15:53:45 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>
Comment-In-Reply-To: dexter <pmaier(a)sysmocom.de>
Gerrit-MessageType: comment