Attention is currently required from: neels, laforge.
pespin has posted comments on this change. (
https://gerrit.osmocom.org/c/libosmocore/+/28286 )
Change subject: add libosmo-gtlv, moved from osmo-upf.git
......................................................................
Patch Set 2:
(1 comment)
Patchset:
PS1:
I agree with @laforge, let's keep same structure for all libs:
I can rename tests/libosmo-gtlv to tests/gtlv.
Yes
Do I have to remove the dash from
"libosmo-gtlv"?
Yes
I'd have to also remove the dash in the places
that use libosmo-gtlv. The dash was fine in osmo-upf.git, I'd like to keep it.
You still need to do modifications there to drop libosmo-gtlv from the repo, so that
can be done at the same time.
I think it's fine keeping it here in libosmocore, changing the above should be pretty
quick.
--
To view, visit
https://gerrit.osmocom.org/c/libosmocore/+/28286
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I25ab400f0c5707fdc0d8e480aca19871c2e26e71
Gerrit-Change-Number: 28286
Gerrit-PatchSet: 2
Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: laforge <laforge(a)osmocom.org>
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Comment-Date: Wed, 15 Jun 2022 10:04:13 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de>
Comment-In-Reply-To: laforge <laforge(a)osmocom.org>
Gerrit-MessageType: comment