Attention is currently required from: arehbein, laforge, pespin.

daniel has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/35079?usp=email )

Change subject: osmo_io: Remove union in struct osmo_io_ops ......................................................................

Patch Set 4:

(1 comment)

Patchset:

PS4:

I'd actually keep the union, imho there's nothing wrong with it if used, plus: […]

Discussion has happened in the issue: https://projects.osmocom.org/issues/6263

The issue with the union is that ioops.write_cb and ioops.sendto_cb are at the same address so setting one and then checking the other does not work. In practice the code has no way to know and will assume it's calling sendto_cb() but is instead calling write_cb().