Attention is currently required from: dexter. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/34058 ) Change subject: pcu_l1_if: add support for PCU_IF_SAPI_AGCH_DT for PCUIF v.11 ...................................................................... Patch Set 1: (2 comments) File src/pcu_l1_if.cpp: https://gerrit.osmocom.org/c/osmo-pcu/+/34058/comment/8bbdd441_83056ca7 PS1, Line 268: /* Send a MAC block via the access gant channel. This will (obviously) only work for MAC blocks that contain access grant https://gerrit.osmocom.org/c/osmo-pcu/+/34058/comment/638c5b06_f74ab89b PS1, Line 321: OSMO_ASSERT(strlen(imsi) > 0); "OSMO_ASSERT(imsi[0] != '\0')" No need to count all bytes everytime for no good reason. -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/34058 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I9effdcec1da91a6e2e7a7c41f95d3300ad1bb292 Gerrit-Change-Number: 34058 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Fri, 04 Aug 2023 10:44:52 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment