laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-iuh/+/36480?usp=email )

Change subject: hnbap_common: Make error message more verbose (which type failed) ......................................................................

hnbap_common: Make error message more verbose (which type failed)

Change-Id: I3d263a2a50afbe1a2a99e52b16e983e0aae22edf --- M src/hnbap_common.c 1 file changed, 13 insertions(+), 4 deletions(-)

Approvals: laforge: Looks good to me, approved pespin: Looks good to me, but someone else must approve Jenkins Builder: Verified

diff --git a/src/hnbap_common.c b/src/hnbap_common.c index 10a29fa..c7678fb 100644 --- a/src/hnbap_common.c +++ b/src/hnbap_common.c @@ -152,7 +152,7 @@ pdu.choice.initiatingMessage.criticality = criticality; rc = ANY_fromType_aper(&pdu.choice.initiatingMessage.value, td, sptr); if (rc < 0) { - LOGP(DHNBAP, LOGL_ERROR, "Error in ANY_fromType_aper\n"); + LOGP(DHNBAP, LOGL_ERROR, "%s: Error in ANY_fromType_aper (%s)\n", __func__, td->name); return NULL; }

@@ -179,7 +179,7 @@ pdu.choice.successfulOutcome.criticality = criticality; rc = ANY_fromType_aper(&pdu.choice.successfulOutcome.value, td, sptr); if (rc < 0) { - LOGP(DHNBAP, LOGL_ERROR, "Error in ANY_fromType_aper\n"); + LOGP(DHNBAP, LOGL_ERROR, "%s: Error in ANY_fromType_aper (%s)\n", __func__, td->name); return NULL; }

@@ -206,7 +206,7 @@ pdu.choice.unsuccessfulOutcome.criticality = criticality; rc = ANY_fromType_aper(&pdu.choice.unsuccessfulOutcome.value, td, sptr); if (rc < 0) { - LOGP(DHNBAP, LOGL_ERROR, "Error in ANY_fromType_aper\n"); + LOGP(DHNBAP, LOGL_ERROR, "%s: Error in ANY_fromType_aper (%s)\n", __func__, td->name); return NULL; }

@@ -234,7 +234,7 @@

rc = ANY_fromType_aper(&buff->value, type, sptr); if (rc < 0) { - LOGP(DHNBAP, LOGL_ERROR, "Error in ANY_fromType_aper\n"); + LOGP(DHNBAP, LOGL_ERROR, "%s: Error in ANY_fromType_aper(%s)\n", __func__, type->name); FREEMEM(buff); return NULL; }