Attention is currently required from: pespin. jolly has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-abis/+/30450 )

Change subject: Send raw data with mISDN as it arrives from application ......................................................................

Patch Set 2:

(1 comment)

File src/input/misdn.c:

https://gerrit.osmocom.org/c/libosmo-abis/+/30450/comment/af62e88d_7571b7b5 PS2, Line 405: osmo_fd_write_disable(bfd);

are you sure this is correct? Shouldn't you only disable it if there's nothing more to be sent?

Write must be disabled in all cases. After sending data to b-channel (PH_DATA_REQ), we need to wait until we receive the confirm (PH_DATA_CNF). A double buffer inside mISDN prevents underruns. The handling of the confirm will enable write again. This is how flow control is performed.