Attention is currently required from: pespin.
jolly has posted comments on this change. (
https://gerrit.osmocom.org/c/libosmo-abis/+/30450 )
Change subject: Send raw data with mISDN as it arrives from application
......................................................................
Patch Set 2:
(1 comment)
File src/input/misdn.c:
https://gerrit.osmocom.org/c/libosmo-abis/+/30450/comment/af62e88d_7571b7b5
PS2, Line 405: osmo_fd_write_disable(bfd);
are you sure this is correct? Shouldn't you only
disable it if there's nothing more to be sent?
Write must be disabled in all
cases. After sending data to b-channel (PH_DATA_REQ), we need to wait until we receive the
confirm (PH_DATA_CNF). A double buffer inside mISDN prevents underruns. The handling of
the confirm will enable write again. This is how flow control is performed.
--
To view, visit
https://gerrit.osmocom.org/c/libosmo-abis/+/30450
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmo-abis
Gerrit-Branch: master
Gerrit-Change-Id: Ib311331fbbeff3661f6745e3474918987a8aa460
Gerrit-Change-Number: 30450
Gerrit-PatchSet: 2
Gerrit-Owner: jolly <andreas(a)eversberg.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 16 Jan 2023 17:38:15 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: comment