Attention is currently required from: pespin.

View Change

1 comment:

• File src/input/misdn.c:

  • Patch Set #2, Line 405: osmo_fd_write_disable(bfd);

    are you sure this is correct? Shouldn't you only disable it if there's nothing more to be sent?

    Write must be disabled in all cases. After sending data to b-channel (PH_DATA_REQ), we need to wait until we receive the confirm (PH_DATA_CNF). A double buffer inside mISDN prevents underruns. The handling of the confirm will enable write again. This is how flow control is performed.

To view, visit change 30450. To unsubscribe, or for help writing mail filters, visit settings.