Attention is currently required from: osmith. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc-nat/+/27465 ) Change subject: treewide: tweak includes ...................................................................... Patch Set 1: (3 comments) Patchset: PS1: To me the new ordering looks messy, sorry. File include/osmocom/bsc_nat/vty.h: https://gerrit.osmocom.org/c/osmo-bsc-nat/+/27465/comment/23e9db0c_657a260d PS1, Line 19: Why removing this line? File src/osmo-bsc-nat/bsc_nat.c: https://gerrit.osmocom.org/c/osmo-bsc-nat/+/27465/comment/d8c3b025_d200326a PS1, Line 23: #include <osmocom/core/talloc.h> Usually includes from libraries come first, and then local headers follow. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc-nat/+/27465 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc-nat Gerrit-Branch: master Gerrit-Change-Id: I1a7b95ccb0c87fd53645c72f0c02449e8403043b Gerrit-Change-Number: 27465 Gerrit-PatchSet: 1 Gerrit-Owner: osmith &lt;osmith(a)sysmocom.de&gt; Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria &lt;vyanitskiy(a)sysmocom.de&gt; Gerrit-Attention: osmith &lt;osmith(a)sysmocom.de&gt; Gerrit-Comment-Date: Thu, 10 Mar 2022 14:49:35 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment