laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/27357 ) Change subject: bitvec2freq_list(): determine empty set by checking the ARFCN count ...................................................................... bitvec2freq_list(): determine empty set by checking the ARFCN count I find it cleaner to relay on the counter ('arfcns' in this case) to check if the set is empty, rather than checking one of the resulting values ('max'). There is just a cosmetic change. Change-Id: I29ca51461beec053bcb8b8210f0ad24bb8c7765f Related: SYS#5854 --- M src/osmo-bsc/system_information.c 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: laforge: Looks good to me, approved Jenkins Builder: Verified diff --git a/src/osmo-bsc/system_information.c b/src/osmo-bsc/system_information.c index 1ebfe5c..93bce77 100644 --- a/src/osmo-bsc/system_information.c +++ b/src/osmo-bsc/system_information.c @@ -553,7 +553,7 @@ max = i; } - if (max == -1) { + if (arfcns == 0) { /* Empty set, use 'bit map 0 format' */ chan_list[0] = 0; return 0; -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/27357 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I29ca51461beec053bcb8b8210f0ad24bb8c7765f Gerrit-Change-Number: 27357 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-MessageType: merged