Attention is currently required from: Hoernchen, pespin.
laforge has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-trx/+/32764 )
Change subject: devices: add freq/gain override for uhd
......................................................................
Patch Set 10:
(2 comments)
File Transceiver52M/device/uhd/UHDDevice.cpp:
https://gerrit.osmocom.org/c/osmo-trx/+/32764/comment/ac869510_a9bf6cd0
PS5, Line 298: if (cfg->overrides.ul_freq_override)
I'm lost here. […]
Done
https://gerrit.osmocom.org/c/osmo-trx/+/32764/comment/8526a769_446ff07a
PS5, Line 344: return 0.0f;
I would expect the power atenuattion to be set to the
overwriten value instead of returning?
Done
--
To view, visit
https://gerrit.osmocom.org/c/osmo-trx/+/32764
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-Change-Id: I3c1b9a067cafc6d696b9aa2da8ee0480ec1e094f
Gerrit-Change-Number: 32764
Gerrit-PatchSet: 10
Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: laforge <laforge(a)osmocom.org>
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 12 Jul 2023 07:48:49 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: comment