Attention is currently required from: laforge, pespin. Hoernchen has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/30633 )
Change subject: logging: add log level cache ......................................................................
Patch Set 9:
(3 comments)
File src/logging.c:
https://gerrit.osmocom.org/c/libosmocore/+/30633/comment/83388ef2_310c724e PS6, Line 107: memset(tmp_level, 100, osmo_log_info->num_cat);
NOT DONE YET
literally done by adding a comment that explains that it is a random big value which is not going to get its own useless define.
https://gerrit.osmocom.org/c/libosmocore/+/30633/comment/014d7d68_d71c6978 PS6, Line 134: struct log_category tmp = { 99, 0 };
NOT DONE YET
literally done by adding a comment that explains that it is a random big value which is not going to get its own useless define.
https://gerrit.osmocom.org/c/libosmocore/+/30633/comment/58022b3a_f6a98855 PS6, Line 145: log_level_lookup_cache[mapped_subsys] = tmp.enabled ? tmp.loglevel : 99;
NOT DONE YET
literally done by adding a comment that explains that it is a random big value which is not going to get its own useless define.
What the function does is described by the preceding comment.
-
Hoernchen