Attention is currently required from: csaba.sipos, laforge. pespin has posted comments on this change by csaba.sipos. ( https://gerrit.osmocom.org/c/osmo-bsc/+/39416?usp=email ) Change subject: nokia_site: Add object_identity, object_state and object_identity_state attributes ...................................................................... Patch Set 21: (7 comments) File src/osmo-bsc/bts_nokia_site.c: https://gerrit.osmocom.org/c/osmo-bsc/+/39416/comment/ce3ba266_d0ab2835?usp… : PS21, Line 1828: get_object_identity_string(object_id_state[4]), wrong indentation https://gerrit.osmocom.org/c/osmo-bsc/+/39416/comment/944d0f5b_780ed6de?usp… : PS21, Line 1860: !FIND_ELEM(noh->data, len_data, NOKIA_EI_OBJ_STATE, &object_state, sizeof(object_state))) { wrong indentation, indent it so that both "!FIND_ELEM" end up in the same column. https://gerrit.osmocom.org/c/osmo-bsc/+/39416/comment/88a4e684_626a7d77?usp… : PS21, Line 1876: get_object_identity_string(object_identity[1]), wrong indentation https://gerrit.osmocom.org/c/osmo-bsc/+/39416/comment/dbfab603_a536451c?usp… : PS21, Line 1884: get_object_identity_string(object_identity[1]), wrong indentation https://gerrit.osmocom.org/c/osmo-bsc/+/39416/comment/68ad6c9d_7a0ea9fb?usp… : PS21, Line 1898: get_object_identity_string(object_identity[1]), wrong indentation https://gerrit.osmocom.org/c/osmo-bsc/+/39416/comment/78ca4f29_d14e153f?usp… : PS21, Line 1907: get_object_identity_string(object_identity[1]), wrong indentation https://gerrit.osmocom.org/c/osmo-bsc/+/39416/comment/40f2d2d5_49429394?usp… : PS21, Line 1916: object_identity[2], wrong indentation -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/39416?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Id9f819b0649ba3c247db72d7d738e49c72388dc3 Gerrit-Change-Number: 39416 Gerrit-PatchSet: 21 Gerrit-Owner: csaba.sipos <metro4(a)freemail.hu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: domi <domi(a)tomcsanyi.net> Gerrit-Attention: csaba.sipos <metro4(a)freemail.hu> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Mon, 10 Feb 2025 09:53:55 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No