[M] Change in osmo-hlr[master]: USSD: fix handling of ussd-DataCodingScheme != 0x0f - gerrit-log

14 Jul 2023


      Attention is currently required from: neels, fixeria, pespin.
osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hlr/+/33528 )
Change subject: USSD: fix handling of ussd-DataCodingScheme != 0x0f
......................................................................
Patch Set 2: Code-Review+1
(2 comments)
File src/hlr_ussd.c:
https://gerrit.osmocom.org/c/osmo-hlr/+/33528/comment/58145f4f_8b709578 
PS2, Line 134: alphabeet
alphabet
https://gerrit.osmocom.org/c/osmo-hlr/+/33528/comment/cea9e8f6_59cf12d4 
PS2, Line 146: 			/* do not abort, attempt to decode as if it was '1111'B */
...
I don't have a strong opinion here. […]
Agreed with fixeria's reasoning.
-- 
To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/33528
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-hlr
Gerrit-Branch: master
Gerrit-Change-Id: Ib7bac660b1a7942adcfbe7b14f162c95061a25db
Gerrit-Change-Number: 33528
Gerrit-PatchSet: 2
Gerrit-Owner: fixeria vyanitskiy@sysmocom.de
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge laforge@osmocom.org
Gerrit-Reviewer: neels nhofmeyr@sysmocom.de
Gerrit-Reviewer: osmith osmith@sysmocom.de
Gerrit-Reviewer: pespin pespin@sysmocom.de
Gerrit-Attention: neels nhofmeyr@sysmocom.de
Gerrit-Attention: fixeria vyanitskiy@sysmocom.de
Gerrit-Attention: pespin pespin@sysmocom.de
Gerrit-Comment-Date: Fri, 14 Jul 2023 08:31:40 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: neels nhofmeyr@sysmocom.de
Comment-In-Reply-To: fixeria vyanitskiy@sysmocom.de
Gerrit-MessageType: comment