Attention is currently required from: pespin.

osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/42119?usp=email )

Change subject: xua_asp_fsm: Validate remote ASP Id matching config in SG role ......................................................................

Patch Set 2: Code-Review+1

(1 comment)

File src/xua_asp_fsm.c:

https://gerrit.osmocom.org/c/libosmo-sigtran/+/42119/comment/be230b14_189d10... : PS2, Line 572: LOGL_NOTICE

In general I think this kind of logging coming from received messages should not log ERROR, since it […]

From logging.h:

``` #define LOGL_DEBUG 1 /*!< debugging information */ #define LOGL_INFO 3 /*!< general information */ #define LOGL_NOTICE 5 /*!< abnormal/unexpected condition */ #define LOGL_ERROR 7 /*!< error condition, requires user action */ #define LOGL_FATAL 8 /*!< fatal, program aborted */ ```

Okay, makes sense.