Attention is currently required from: fixeria, pespin.
laforge has posted comments on this change by pespin. (
https://gerrit.osmocom.org/c/osmo-hnbgw/+/39983?usp=email )
Change subject: Rename function s/hnbgw_decode_ranap_co/hnbgw_decode_ranap_cn_co/g
......................................................................
Patch Set 1: Code-Review+1
(2 comments)
File src/osmo-hnbgw/context_map_rua.c:
https://gerrit.osmocom.org/c/osmo-hnbgw/+/39983/comment/8e8d1cc7_b30294c4?u… :
PS1, Line 140: hnbgw_decode_ranap_cn_co
That's how all code in osmo-iuh is named. […]
Acknowledged
https://gerrit.osmocom.org/c/osmo-hnbgw/+/39983/comment/ef8a784d_6d96b062?u… :
PS1, Line 148: rc = ranap_cn_rx_co_decode2(message, msgb_l2(ranap_msg),
msgb_l2len(ranap_msg));
See how it matches this osmo-iuh naming.
"cn".
Acknowledged
--
To view, visit
https://gerrit.osmocom.org/c/osmo-hnbgw/+/39983?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-hnbgw
Gerrit-Branch: master
Gerrit-Change-Id: Ia4e5a21a9724ebf759b62c13759a776189b09e91
Gerrit-Change-Number: 39983
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 09 Apr 2025 20:28:18 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: laforge <laforge(a)osmocom.org>
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>