Attention is currently required from: neels, laforge, fixeria, pespin, dexter. iedemam has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/28276 )
Change subject: Expand VTY option which controls use of TCH for signalling ......................................................................
Patch Set 8:
(6 comments)
Patchset:
PS8: Hi Pau,
Good points, thanks! Hopefully I've addressed them now.
-Michael
File include/osmocom/bsc/bts.h:
https://gerrit.osmocom.org/c/osmo-bsc/+/28276/comment/7f3e4057_31dbf5ce PS5, Line 263: BTS_TCH_SIGNALLING_NEVER,
Maybe NEVER->NONE and ALWAYS->ALL would be more meanginful, but not really sure about it, so letting […]
The description in VTY phrases it as "when can we use TCH" and so I named these accordingly.
File src/osmo-bsc/abis_rsl.c:
https://gerrit.osmocom.org/c/osmo-bsc/+/28276/comment/f2276593_65d89920 PS5, Line 2177: /* else: Emergency calls will be put on a free TCH/H or TCH/F directly
We should probably discuss this. […]
Agreed. I have now added this.
https://gerrit.osmocom.org/c/osmo-bsc/+/28276/comment/4d7ac89b_f144235d PS5, Line 2181: if (bts->tch_for_signalling_policy == BTS_TCH_SIGNALLING_ALWAYS
If you don't mind, this would be probably more readable, since the same check is done first: […]
Done
File src/osmo-bsc/bts_vty.c:
https://gerrit.osmocom.org/c/osmo-bsc/+/28276/comment/ea7c36d4_f688aacd PS5, Line 568: chan_alloc_allow
Why are you removing this part? […]
This have been renamed back to contain "chan_alloc", That was a mistake on my part not realizing the name referred to VTY text as well.
https://gerrit.osmocom.org/c/osmo-bsc/+/28276/comment/eba27a84_61d1d918 PS5, Line 582: !strcmp(argv[0], "0")
argv[0] can not be "0" or "1" anymore (because you've changed the command vector from '0|1' to 'neve […]
I have added a DEPRECATED version of the command. Maybe it is still not correct?
-
iedemam