[L] Change in osmo-ttcn3-hacks[master]: MME_Tests: add testcase TC_RIM_RAN_INF - gerrit-log

5 Aug 2023


      Attention is currently required from: fixeria, pespin, dexter.
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33937 )
Change subject: MME_Tests: add testcase TC_RIM_RAN_INF
......................................................................
Patch Set 4:
(1 comment)
File mme/MME_Tests.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33937/comment/cff5b6b6_e4ea3... 
PS4, Line 689: private function f_TC_RIM_RAN_INF_REQ_req_make_rIMInformation(GTP_CellId geran_gtp_ci, boolean ts)
tbh, I don't like this kind of function where you return a generic, unqualified template and pass in a boolean argument to decide whether or not you want a send or receive template.  This means you loose the qualifier between input and return value of this function.
-- 
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33937
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I22d5aaab64df2824099977fb574afb86a4b7e91f
Gerrit-Change-Number: 33937
Gerrit-PatchSet: 4
Gerrit-Owner: dexter pmaier@sysmocom.de
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge laforge@osmocom.org
Gerrit-Reviewer: pespin pespin@sysmocom.de
Gerrit-CC: fixeria vyanitskiy@sysmocom.de
Gerrit-Attention: fixeria vyanitskiy@sysmocom.de
Gerrit-Attention: pespin pespin@sysmocom.de
Gerrit-Attention: dexter pmaier@sysmocom.de
Gerrit-Comment-Date: Sat, 05 Aug 2023 07:54:56 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment