Attention is currently required from: fixeria.

laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/33347 )

Change subject: Add support for encoding/decoding SMS in TPDU and SMPP format ......................................................................

Patch Set 3:

(2 comments)

File contrib/jenkins.sh:

https://gerrit.osmocom.org/c/pysim/+/33347/comment/834ea57f_4a020166 PS1, Line 25: pip install git+https://github.com/hologram-io/smpp.pdu

Is this really needed given that you adding this dep to `requirements. […]

thanks, it is indeedredundant.

File ota_test.py:

https://gerrit.osmocom.org/c/pysim/+/33347/comment/061cdf96_fd492d08 PS1, Line 1: #!/usr

`/usr/bin/env python3` please

that entire script should go, it's not for this commit, and has meanwhile been converted to proper python unittest. sorry.