Attention is currently required from: daniel, laforge, pespin.
neels has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-mgw/+/39248?usp=email )
Change subject: mgw: Decouple SDP parsing step from conn obj update ......................................................................
Patch Set 4:
(3 comments)
File include/osmocom/mgcp/mgcp_protocol.h:
https://gerrit.osmocom.org/c/osmo-mgw/+/39248/comment/9aa6d6e4_f577b617?usp=... : PS3, Line 13: #define MGCP_PARSE_SDP_MAXPTIME_UNSET (-1)
It's not duplicate, it's two different fields.
ah, i thought it was an enum =)
https://gerrit.osmocom.org/c/osmo-mgw/+/39248/comment/763d4bd6_a49fbb8d?usp=... : PS3, Line 14: #define MGCP_PARSE_SDP_RTP_PORT_UNSET (0)
It's not a closed set of values, but a specific value in an int range, it's fine as a define.
ack
File src/libosmo-mgcp/mgcp_protocol.c:
https://gerrit.osmocom.org/c/osmo-mgw/+/39248/comment/b65a0be5_6b7de7e5?usp=... : PS3, Line 1139: if (rc < 0) { /* See also RFC 3661: Protocol error */
I'm actually fine with it the current way, but changing in to avoid discussions.
yay! =)
-
neels